Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): validation of httpAgent config #4484

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • fix the validation of httpAgent config. we could now pass ca, instead of key/cert.
{
  helpers: {
    REST: {
      endpoint: 'http://site.com/api',
      prettyPrintJson: true,
      httpAgent: {
         ca: fs.readFileSync(__dirname + '/path/to/ca.pem'),
         rejectUnauthorized: false,
         keepAlive: true
      }
    }
  }
}

Applicable helpers:

  • REST

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent changed the title fix(rest): httpAgent condition fix(rest): validation of httpAgent config Sep 4, 2024
@kobenguyent kobenguyent merged commit 3d42884 into 3.x Sep 4, 2024
11 of 13 checks passed
@kobenguyent kobenguyent deleted the fix-REST-helper-httpAgent branch September 4, 2024 11:10
@kobenguyent kobenguyent mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant