Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify bash shell on run steps #125

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Explicitly specify bash shell on run steps #125

merged 4 commits into from
Apr 4, 2022

Conversation

cafarm
Copy link
Contributor

@cafarm cafarm commented Jan 15, 2022

This change explicitly defines the bash shell on the run steps in the orb.

Why? On Windows, the default executor shell is PowerShell, which means if someone uses this orb without overriding the default shell the orb commands will fail to run because they will attempt to run in PowerShell.

@cafarm
Copy link
Contributor Author

cafarm commented Jan 22, 2022

Looks like the job does not have access to the ORB_PUBLISH_TOKEN secret. Someone with appropriate permissions probably needs to re-run the job.

@thomasrockhu-codecov thomasrockhu-codecov changed the title [semver:patch] Explicitly specify bash shell on run steps Explicitly specify bash shell on run steps Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants