Fix CIRCLE_BUILD_NUM bug and allows users to specify env vars as flags #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the ${CIRCLE_BUILD_NAME} upload name bug
by changing the upload_name parameter default string from
"${CIRCLE_BUILD_NUM}" to the empty string, then modifying
`upload.sh` to replace the PARAM_UPLOAD_NAME env var with
the contents of CIRCLE_BUILD_NUM if PARAM_UPLOAD_NAME
is the empty string.
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
This commit allows users to specify an environment variable as a flag. The codecov uploader will use the contents of the environment variable as the flags when it runs. This commit checks if the string specified in PARAM_FLAGS corresponds to an env var and if it does it passes the contents to the flags option of the uploader. If it doesn't then it uses the PARAM_FLAGS string itself. Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 4 4
=========================================
Hits 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/circle-build-num-and-env-var-flags
branch
from
85c0d6d
to
3360850
Compare
thomasrockhu-codecov
requested changes
Jul 21, 2023
src/commands/upload.yml
Outdated
| @@ -13,7 +13,9 @@ parameters: | |||
| default: "" | |||
| flags: | |||
| description: Flag the upload to group coverage metrics (e.g. unittests | |||
| | integration | ui,chrome) | |||
| | integration | ui,chrome). If the name of an environment | |||
There was a problem hiding this comment.
If the name of an environment variable is provided as a flag then the value of that environment environment variable will be used.
This is a bit wordy. Can we do something like
Flags can be input as strings or environment variables.
.circleci/test-deploy.yml
Outdated
| @@ -80,6 +84,10 @@ jobs: | |||
| file: coverage/coverage-final.json | |||
| flags: linux | |||
| version: v0.1.0_8880 | |||
| - codecov/upload: | |||
| flags: frontend,ENV_VAR_FLAG | |||
There was a problem hiding this comment.
can we use flag names that are more relevant here?
There was a problem hiding this comment.
For the flags themselves, or for the name of the environment variable?
There was a problem hiding this comment.
names of the flags. backend and frontend are already used
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/circle-build-num-and-env-var-flags
branch
from
557bcca
to
7f38290
Compare
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
thomasrockhu-codecov
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ${CIRCLE_BUILD_NUM} bug in the upload name.
This PR allows users to specify environment variables that specify the
flags to be used in the uploader.
Fixes: codecov/engineering-team#83