Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:patch] Fix issue with Windows curling the bash script #88

Merged
merged 2 commits into from
May 26, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented May 26, 2021

Using the given params expects a password for user tfile. This should not be necessary.

@thomasrockhu thomasrockhu requested a review from a team May 26, 2021 02:07
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as it works :)

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #88 (a0b1332) into master (d7ce050) will not change coverage.
The diff coverage is n/a.

❗ Current head a0b1332 differs from pull request most recent head cb97069. Consider uploading reports for the commit cb97069 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           3        3           
  Lines          18       18           
=======================================
  Hits           16       16           
  Misses          2        2           
Flag Coverage Δ
backend 85.71% <ø> (ø)
frontend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ce050...cb97069. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants