Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #165: Place script/argument files in target #173

Closed
wants to merge 1 commit into from

Conversation

zregvart
Copy link
Contributor

With this the arguments and java.[sh|bat files will be created in the
build directory (usually target), rather than in the output directory
(usually target/classes).

Fixes #165

@zregvart zregvart changed the title Issue: #165: Place script/argument files in target Issue #165: Place script/argument files in target Dec 17, 2021
With this the arguments and `java.[sh|bat` files will be created in the
build directory (usually `target`), rather than in the output directory
(usually `target/classes`).

Fixes codehaus-plexus#165
@urld
Copy link

urld commented Dec 17, 2021

I think this would lead to compile and testCompile overwriting each others javac.sh file. Maybe a prefix is needed.

@urld
Copy link

urld commented Dec 17, 2021

It looks like there is already a directory structure that differentiates between the different compile targets:
target/maven-status/maven-compiler-plugin/compile/default-compile
target/maven-status/maven-compiler-plugin/testCompile/default-testCompile

@zregvart
Copy link
Contributor Author

I do admit making these changes without much consideration. And I did not provide a test. I'm sorry about that I'm rather short on time at the moment.

@olamy
Copy link
Member

olamy commented Feb 7, 2022

done here #184
we have to change the name as well as javac.sh is generated for both classes and test classes.
not changing the name will be lost of javac.sh for main classes as it will be overriden by the test javac.sh

@olamy olamy closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't create javac.[sh|bat] or org.codehaus.plexus.compiler.javac.JavacCompiler*arguments in target/*classes
3 participants