[eclipse-compiler] Resort sources to have module-info.java first #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the contribution. Can you please provide a unit test so we are sure this ordering will not be lost in case of some other changes |
|
Hi @olamy - thanks for checking. UT for new method was added. I tried to prepare IT, but due to I would not bother this repository with the change, as ECJ will have their fix released eventually, and I suppose it happens in very few cases +in JPMS projects only, but unfortunately I'm impacted. Just wanted to share my finding as I'm patched already 😁 |
olamy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch compiler: unexpected errors if module-info.java doesn't come first