simplify "Compiling" info message: display relative path #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
approved these changes
Dec 13, 2022
pzygielo
reviewed
Dec 13, 2022
| getLogger().info( "Compiling " + sourceFiles.length + " " + | ||
| "source file" + ( sourceFiles.length == 1 ? "" : "s" ) + | ||
| " to " + destinationDir.getAbsolutePath() ); | ||
| " to " + to ); |
There was a problem hiding this comment.
Could these duplications be avoided?
There was a problem hiding this comment.
Could these duplications be avoided?
?? not sure to understand your concern?
There was a problem hiding this comment.
you mean create a logCompiling() method in AbstractCompiler for logging, and have plexus compilers use this method?
There was a problem hiding this comment.
to and message logged/being output are calculated twice (Javac, AspecJCompiler) in the same way.
There was a problem hiding this comment.
good idea, done in 37f6843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify current info message
by replacing full path with relative to basedir: