Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 11 for plexus-compiler-eclipse an javac-errorprone and aspectj compilers #279

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

slachiewicz
Copy link
Member

No description provided.

@slachiewicz slachiewicz merged commit a5775b2 into master Apr 15, 2023
@slachiewicz slachiewicz deleted the java-11-only branch April 15, 2023 20:06
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you could wait for review before merging??

<properties>
<junit.version>4.13.2</junit.version>
<maven.compiler.source>11</maven.compiler.source>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using release?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netbeans would show this as warning, assuming it can figure out the compiler plugin version :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to improve opening pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants