Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy providers and better error reporting #361

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Lazy providers and better error reporting #361

merged 4 commits into from
Feb 21, 2024

Commits on Feb 4, 2024

  1. ITs need plugin dependency to plexus-compiler-manager 

    While testing codehaus-plexus#347, changes in compiler manager were not pulled into
ITs, because Maven Compiler has a dependency on it, which must be
overridden in all ITs or in projects using Plexus Compiler generally, if
they need to override the version predefined by Maven Compiler.
    @kriegaex
    kriegaex committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    e7282ba View commit details
    Browse the repository at this point in the history

  2. Lazy providers and better error reporting 

    If scanning, injection or construction fails, log a comprehensive error
message on top of throwing a NoSuchCompilerException.

Fixes codehaus-plexus#347.

Co-authored-by: Alexander Kriegisch <Alexander@Kriegisch.name>
    @cstamas @kriegaex
    cstamas and kriegaex committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a3c52c6 View commit details
    Browse the repository at this point in the history

  3. Code review: throw exception with cause 

    In order to be able to do that at all, I had to add a constructor taking
a throwable first. Now, even though a cause is propagated, at the time
of writing this Maven Compiler will just catch the
NoSuchCompilerException we throw, ignore its message and root cause and
throw a new MojoExecutionException instead. :-/

Relates to codehaus-plexus#347.
    @kriegaex
    kriegaex committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    ad1164b View commit details
    Browse the repository at this point in the history

  4. Code review: improve DefaultCompilerManager.ERROR_MESSAGE 

    Add more detail concerning possible user errors like misspelling the
compiler ID or missing dependencies for a compiler.

Relates to codehaus-plexus#347.
    @kriegaex
    kriegaex committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    90960d1 View commit details
    Browse the repository at this point in the history