Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename method, now that EA of JDK 16 is available #79

Merged
merged 1 commit into from Jul 6, 2020
Merged

Rename method, now that EA of JDK 16 is available #79

merged 1 commit into from Jul 6, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jun 16, 2020 •
edited
Loading

Seems that travis has issue with delivering check status:
✔️ 705367362

@pzygielo pzygielo marked this pull request as ready for review June 16, 2020 13:03
@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 6, 2020

May I ask for review, please?

michael-o
michael-o reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about isPreJava1_6()? Have never seen using dot.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 6, 2020

What about isPreJava1_6()?

Should do. Seems no checkstyle is configured to enforce [a-z][a-zA-Z0-9]* method name pattern.

@pzygielo pzygielo marked this pull request as draft July 6, 2020 11:38
@pzygielo pzygielo marked this pull request as ready for review July 6, 2020 11:48
@pzygielo pzygielo requested a review from michael-o July 6, 2020 11:48
@michael-o michael-o merged commit b756192 into codehaus-plexus:master Jul 6, 2020
@pzygielo pzygielo deleted the pre16 branch July 6, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzygielo @michael-o