Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ValidationInterface::getValidated() #7429

Merged
merged 2 commits into from
Apr 15, 2023
Merged

feat: add ValidationInterface::getValidated() #7429

merged 2 commits into from
Apr 15, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 13, 2023 •
edited
Loading

Description
Follow-up #7420

PHPStan reports when using $this->validator->getValidated() in Controller:

Call to an undefined method CodeIgniter\Validation\ValidationInterface::getValidated().

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities breaking change Pull requests that may break existing functionalities 4.4 labels Apr 13, 2023
@kenjis kenjis merged commit 298a392 into codeigniter4:4.4 Apr 15, 2023
@kenjis kenjis deleted the add-ValidationInterface-getValidated branch April 15, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
4.4 breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @paulbalandan @ddevsr