-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: highlightFile()
in BaseExceptionHandler
for PHP 8.3
#8401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
Verified issues on the current code behavior or pull requests that will fix them
label
Jan 5, 2024
lonnieezell
approved these changes
Jan 5, 2024
https://github.com/codeigniter4/CodeIgniter4/actions/runs/7422018813/job/20196514237?pr=8401 |
Yes, I'm not sure why it fails on PHP 7.4... and I don't have it locally to test 😐 |
Silly me... the result for PHP 7.4 is slightly different again. Fixed. |
kenjis
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8399
Fixes #8398
This PR fixes issues with
highlightFile()
method.The source of the problem is the fact that the
highlight_file()
function has slightly changed its behavior in PHP 8.3.A nice summary can be found here:
https://php.watch/versions/8.3/highlight_file-highlight_string-html-changes
Except for the changes in the
highlight_file()
function, this PR also fixes some issues found in closing openedspan
tags.I added some changes to the way
$source
variable is handled after noticing @kenjis PR: #8399.Checklist: