docs: fix phpstan ignored errors in app/ and admin/starter/tests/ #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamweb
reviewed
Mar 21, 2024
app/Config/Logger.php
Outdated
| @@ -72,6 +72,8 @@ class Logger extends BaseConfig | |||
| * | |||
| * Handlers are executed in the order defined in this array, starting with | |||
| * the handler on top and continuing down. | |||
| * | |||
| * @var array<string, array<string, int|list<string>|string>> | |||
There was a problem hiding this comment.
FileHandler::class is string or class-string?
There was a problem hiding this comment.
It's class-string. Fixed.
datamweb
reviewed
Mar 21, 2024
app/Config/Routing.php
Outdated
| @@ -106,7 +108,7 @@ class Routing extends BaseRouting | |||
| * 'blog' => 'Acme\Blog\Controllers', | |||
| * ] | |||
| * | |||
| * @var array [ uri_segment => namespace ] | |||
| * @var array<string, string> [ uri_segment => namespace ] | |||
There was a problem hiding this comment.
The example(E.g.) is clear to me, I think [ uri_segment => namespace ] is not needed.
datamweb
reviewed
Mar 21, 2024
system/Config/Routing.php
Outdated
| @@ -104,7 +106,7 @@ class Routing extends BaseConfig | |||
| * 'blog' => 'Acme\Blog\Controllers', | |||
| * ] | |||
| * | |||
| * @var array [ uri_segment => namespace ] | |||
| * @var array<string, string> [ uri_segment => namespace ] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
admin/starter/testsby PHPStanChecklist: