fix: Time loses microseconds #9081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
paulbalandan
approved these changes
Jul 26, 2024
|
This may break existing apps. So I will send it to |
kenjis
added
the
breaking change
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
from
06bbcca
to
8fdd362
Compare
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
2 times, most recently
from
4e892ef
to
da64622
Compare
|
Added the docs, and fixed a bug in Time::toDateTime(). |
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
2 times, most recently
from
381f396
to
5a2a67c
Compare
|
Fixed |
michalsn
approved these changes
Jul 27, 2024
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
from
5a2a67c
to
d438d05
Compare
paulbalandan
approved these changes
Jul 28, 2024
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
2 times, most recently
from
c68a3fb
to
56c6c46
Compare
|
Fixed |
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
fix-Time-loses-microseconds
branch
from
dea9d5b
to
ed29b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9079
Since PHP 7.1, DateTime constructor incorporates microseconds.
See https://www.php.net/manual/en/migration71.incompatible.php#migration71.incompatible.datetime-microseconds
and
Timeconstructor also holds microseconds in most cases.But some methods below in
Timelost microseconds.__construct()... not all casescreateFromFormat()createFromInstance()toDateTime()setTestNow()equals()sameAs()isBefore()isAfter()Also fixes:
DatetimeCast::set()Checklist: