Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.6] fix: inconsistency in detailed error reporting #9144

Merged
merged 3 commits into from
Aug 30, 2024
Merged

[4.6] fix: inconsistency in detailed error reporting #9144

merged 3 commits into from
Aug 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 23, 2024

Description
See #9120 (comment)

  • fix the condition to show error details for non-HTML requests

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.6 labels Aug 23, 2024
@kenjis kenjis mentioned this pull request Aug 23, 2024
Closed
@kenjis kenjis changed the title fix: inconsistency in detailed error reporting [4.6] fix: inconsistency in detailed error reporting Aug 23, 2024
@kenjis kenjis merged commit 675c819 into codeigniter4:4.6 Aug 30, 2024
42 checks passed
@kenjis kenjis deleted the fix-inconsistency-in-detailed-error-reports branch August 30, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.6 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn