Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable TypedPropertyFromAssignsRector #9184

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor: enable TypedPropertyFromAssignsRector #9184

merged 1 commit into from
Sep 10, 2024
+6 −4

Conversation

samsonasik
Copy link
Member

Description

To make private property typed by assign.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @kenjis for the review, let's merge 👍

@samsonasik samsonasik merged commit 092d85b into codeigniter4:develop Sep 10, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-typed-property branch September 10, 2024 09:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @kenjis