Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: navigation #115

Merged
merged 3 commits into from
Dec 22, 2023
Merged

docs: navigation #115

merged 3 commits into from
Dec 22, 2023

Conversation

michalsn
Copy link
Member

Description
This PR:

  • adds site_url, to make navigation.instant feature work
  • fixes the way hljs is initialized to work well with navigation.instant feature
  • removes navigation.instant.prefetch feature because it's available only for sponsors of the MkDocs project

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit 0f0d9d2 into codeigniter4:develop Dec 22, 2023
@michalsn michalsn deleted the docs-navigation branch January 4, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @lonnieezell @kenjis