Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow current settings to be completely cleared out. #116

Merged
merged 7 commits into from
Jan 6, 2024

Conversation

lonnieezell
Copy link
Member

Description
Added a new command, flush() to the drivers. This allows for easily resetting during testing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

src/Commands/ClearSettings.php Outdated Show resolved Hide resolved
src/Commands/ClearSettings.php Outdated Show resolved Hide resolved
@lonnieezell
Copy link
Member Author

Tools are annoying once again lol. I saw the comment getting moved in the previous results so I modified that locally. Ran cs-fix and it moved it back. Pushed the code up and it was mad because I didn't push it farther in. /sigh

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one last thing, but this looks ready.

src/Commands/ClearSettings.php Outdated Show resolved Hide resolved
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@lonnieezell lonnieezell merged commit 2748f2b into develop Jan 6, 2024
31 checks passed
@lonnieezell lonnieezell deleted the test-support branch January 6, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants