Skip to content

Commit

Permalink
move $matrix outside foreach loop
Browse files Browse the repository at this point in the history
  • Loading branch information
christianberkman committed Aug 22, 2024
1 parent 60f1ae3 commit c0268d9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Authorization/Traits/Authorizable.php
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ public function can(string ...$permissions): bool
// Check the groups the user belongs to
$this->populateGroups();

// Get the group matrix
$matrix = setting('AuthGroups.matrix');

foreach ($permissions as $permission) {
// Permission must contain a scope and action
if (strpos($permission, '.') === false) {
Expand All @@ -270,8 +273,6 @@ public function can(string ...$permissions): bool
return false;
}

$matrix = setting('AuthGroups.matrix');

foreach ($this->groupCache as $group) {
// Check exact match
if (isset($matrix[$group]) && in_array($permission, $matrix[$group], true)) {
Expand Down

0 comments on commit c0268d9

Please sign in to comment.