refactor: remove unneeded Entities\Cast\IntBoolCast #1187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for sending this PR. |
|
@kenjis The unsuccessful checks appear to be during phpstan and rector complaining that they can no longer find the IntBoolCast and Entity classes. Those are unneeded and therefore deleted. Not sure how to fix the GitHub actions. |
php stand mods
|
The commit is not GPG signed. Please sign all commits. |
|
@kenjis I'll have to open a new PR. I used the web editor and was trying to squash the php stan edits as I couldn't do it on the web. Sorry about that. |
|
Okay, no problem. But I recommend you learn how to use:
If you learn them, you could manipulate git commits freely and easily on your local machine.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopening of Pull Request #1186 as I deleted the repository prematurely.