Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve query performance for find*() #1192

Closed

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Aug 31, 2024

Description
This Pull Request introduces a database migration that adds an index to the deleted_at column in the users table. This change is intended to enhance the performance of queries that filter based on the deleted_at field, particularly for cases involving soft deletes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the enhancement New feature or request label Aug 31, 2024
@kenjis
Copy link
Member

kenjis commented Aug 31, 2024

This needs to be carefully considered.
See https://tech-torana-co-jp.translate.goog/entry/2023/11/27/123000?_x_tr_sl=ja&_x_tr_tl=en&_x_tr_hl=ja&_x_tr_pto=wapp

@datamweb
Copy link
Collaborator Author

datamweb commented Sep 2, 2024

Hi Kenjis,
I did some research on this and it seems like it won’t have a positive impact. So, I’m going to close it. Thanks for the link you shared!"

@datamweb datamweb closed this Sep 2, 2024
@datamweb datamweb deleted the add-index-to-delete_at branch September 2, 2024 15:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants