Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add inotify support for linux #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add inotify support for linux #5

wants to merge 1 commit into from

Conversation

schnipseljagd
Copy link

This should keep all existing functionality for OS X.

cc: @fstehle @bracki @p0wl

@p0wl
Copy link

p0wl commented Feb 3, 2016

👍

p0wl
p0wl reviewed Feb 3, 2016
View reviewed changes
lib/fsevents_to_vm/fs_event_proxy.rb
block.call(event)
end
elsif is_linux?
@notifier.watch(@path, :recursive, :attrib, :modify, :move, :create, :delete) do |event|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schnipseljagd does delete work? (see https://github.com/codekitchen/fsevents_to_vm/blob/master/lib/fsevents_to_vm/watch.rb#L26-L27)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schnipseljagd @p0wl