Warn if editor session manager socket cannot be created.

[sleexyz]

Fixes #6275

[codecov]

Codecov Report

Merging #6277 (8b27c26) into main (fdeaba9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6277      +/-   ##
==========================================
+ Coverage   73.56%   73.60%   +0.04%     
==========================================
  Files          31       31              
  Lines        1861     1864       +3     
  Branches      399      399              
==========================================
+ Hits         1369     1372       +3     
  Misses        415      415              
  Partials       77       77              

Impacted Files	Coverage Δ
src/node/main.ts	51.04% <100.00%> (+0.51%)	⬆️
src/node/vscodeSocket.ts	87.61% <100.00%> (+0.24%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3c9ed...8b27c26. Read the comment docs.

[code-asher]

Thank you for responding so quickly!

One wrinkle is that the logs would say Session server listening on undefined. One idea is to return undefined if there is an error and in main.ts branch based on that.

if (server) {
  logger.info("Server listening etc")
} else {
  logger.error("failed etc etc")
}

Or we could have a server.isListening property or something like that. Wait we could just branch on the address itself since that would be undefined.

[sleexyz]

Wait we could just branch on the address itself since that would be undefined.

Done!

[code-asher]

Awesome, love the test too!

[code-asher]

It looks like the other PR also included these changes so I decided to tweak the commit message on the other and merge in just that one. Thanks again!