Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Don't create Secret if existingSecret is provided #6397

Merged
merged 1 commit into from
Aug 28, 2023
Merged

feat(helm): Don't create Secret if existingSecret is provided #6397

merged 1 commit into from
Aug 28, 2023

Conversation

AntoineFr
Copy link
Contributor

When I set existingSecret in values.yaml, a secret is still created even if it's not used. This PR removes it.

Tests

# secret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: my-secret
type: Opaque
stringData:
  password: MySuperSecretPassword
# values.yaml
existingSecret: my-secret

Before

# helm template ./ci/helm-chart -s templates/secrets.yaml
---
# Source: code-server/templates/secrets.yaml
apiVersion: v1
kind: Secret
metadata:
  name: release-name-code-server
  annotations:
    "helm.sh/hook": "pre-install"
  labels:
    app.kubernetes.io/name: code-server
    helm.sh/chart: code-server-3.12.1
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
type: Opaque
data:
# Here was a blank line I also removed in my PR
  password: "THh6aGdDYWZrUjMzNXlwdmxlbk95Z0g0"

After

Error: could not find template templates/secrets.yaml in chart

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher merged commit eb8099f into coder:main Aug 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants