Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code to 1.93.0 #6984

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Update Code to 1.93.0 #6984

merged 6 commits into from
Sep 19, 2024

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Sep 6, 2024

Fixes #6955

@benz0li benz0li requested a review from a team as a code owner September 6, 2024 13:38
@benz0li
Copy link
Contributor Author

benz0li commented Sep 7, 2024

Ping @code-asher: code-server-4.93.0-rc.1-linux-amd64.tar.gz with Code 1.93.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2024.8.0
  • ms-python.python@2024.14.0

@renkun-ken: R Extension: The first plot command does not open the "R Plot" window. The window only opens after the second plot command.
👉 You can reproduce it yourself at https://coder.jupyter.b-data.ch yourself. Log in with your GitHub account.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 8, 2024

Ping @randy3k: R Extension: The first plot command does not open the "R Plot" window. The window only opens after the second plot command.
👉 You can reproduce it yourself at https://coder.jupyter.b-data.ch yourself. Log in with your GitHub account.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 9, 2024

FYI @renkun-ken @randy3k: The browser console states

[REditorSupport.r]request to http://127.0.0.1:38103/plots failed, reason: socket hang up [mainThreadExtensionService.ts:78:10]

FetchError: request to http://127.0.0.1:38103/plots failed, reason: socket hang up
	at ClientRequest.<anonymous> (/opt/code-server/lib/vscode/extensions/reditorsupport.r-2.8.4-universal/dist/extension.js:2:1943428)
	at ClientRequest.emit (node:events:519:28)
	at emitErrorEvent (node:_http_client:108:11)
	at Socket.socketOnEnd (node:_http_client:535:5)
	at Socket.emit (node:events:531:35)
	at endReadableNT (node:internal/streams/readable:1696:12)
	at process.processTicksAndRejections (node:internal/process/task_queues:82:21) [mainThreadExtensionService.ts:79:10]

ℹ️ This does not happen with previous versions of code-server.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 9, 2024

@code-asher Please check the failing Firefox upload/download end-to-end tests.

Thank you.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 13, 2024

@code-asher Code 1.93.1 is out. Unfortunately, I do not have the time to update this PR.

You are on your own.

@code-asher
Copy link
Member

I will try to get to it today, but it might be next week...

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@50c6abf). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6984   +/-   ##
=======================================
  Coverage        ?   72.63%           
=======================================
  Files           ?       31           
  Lines           ?     1904           
  Branches        ?      412           
=======================================
  Hits            ?     1383           
  Misses          ?      441           
  Partials        ?       80           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c6abf...a95331d. Read the comment docs.

@code-asher code-asher force-pushed the code-1.93.0 branch 2 times, most recently from a15d241 to aa04434 Compare September 19, 2024 07:17
@benz0li
Copy link
Contributor Author

benz0li commented Sep 19, 2024

@code-asher Thanks for all your efforts.

@code-asher code-asher force-pushed the code-1.93.0 branch 2 times, most recently from 9c4d5a6 to f005242 Compare September 19, 2024 09:29
@code-asher
Copy link
Member

Still not sure what is going on with context menus in Firefox, but I verified the tests manually so for now I am going to disable them and experiment later. Will merge now and get a release out soon-ish.

@code-asher
Copy link
Member

Also @benz0li thanks for getting the update started!

@code-asher code-asher merged commit 3542bd1 into coder:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Code to 1.93
2 participants