Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release: test migrations before building #13051

Merged
merged 4 commits into from
Apr 24, 2024
Merged

ci: release: test migrations before building #13051

merged 4 commits into from
Apr 24, 2024

Conversation

johnstcn
Copy link
Member

  • Adds step to test migrations before releasing.
  • Modifies test-migrations target to avoid using migrate-ci

@johnstcn johnstcn self-assigned this Apr 23, 2024
deansheather
deansheather reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work when testing cherry pick releases?

Makefile Outdated Show resolved Hide resolved
@johnstcn
Copy link
Member Author

Does this work when testing cherry pick releases?

The script stands up a test database, runs the migrations from $COMMIT_FROM, runs the migrations from $COMMIT_TO, dumps the schema, and diffs it against $COMMIT_TO:dump.sql.
I don't think it should make any difference between a cherry-picked commit or not.

mtojek
mtojek reviewed Apr 23, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@mtojek
Copy link
Member

mtojek commented Apr 24, 2024

Related: #13008

Can we merge it now and resolve the issue?

@johnstcn johnstcn merged commit a04c76c into main Apr 24, 2024
28 checks passed
@johnstcn johnstcn deleted the cj/fixup-makefile-test-migrations branch April 24, 2024 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnstcn @mtojek @deansheather