Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write.go: Fix deadlock in writeFrame #253

Merged
merged 1 commit into from
Jul 5, 2020
Merged

write.go: Fix deadlock in writeFrame #253

merged 1 commit into from
Jul 5, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 4, 2020

Closes #248

Luckily, due to the 5s timeout on the close handshake, this would have
had very minimal effects on anyone in production.

Closes #248

Luckily, due to the 5s timeout on the close handshake, this would have
had very minimal effects on anyone in production.
@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 4, 2020

Please review @RTann!

@nhooyr nhooyr changed the title write.go: Fix deadlock in writeFrame write: Fix deadlock in writeFrame Jul 4, 2020
@nhooyr nhooyr changed the title write: Fix deadlock in writeFrame write.go: Fix deadlock in writeFrame Jul 4, 2020
Copy link

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 5, 2020

Thanks for reviewing!

@nhooyr nhooyr merged commit 897a573 into dev Jul 5, 2020
@nhooyr nhooyr deleted the fix-deadlock branch July 5, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants