106-add-logger-configuration #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpad
reviewed
Dec 1, 2023
gpad
reviewed
Dec 1, 2023
gpad
approved these changes
Dec 1, 2023
tarzacodes
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Add logger configuration * Minor fixes * Try a new version of rabbit * Try the same rabbit version as dotnet * Fix in decode response * Remove winston from deps * Remove async await from createConnection * Revert of undefined check --------- Co-authored-by: magne <magnello@coders51.com>
l4mby
added a commit
that referenced
this pull request
Dec 6, 2023
* Add logger configuration * Minor fixes * Try a new version of rabbit * Try the same rabbit version as dotnet * Fix in decode response * Remove winston from deps * Remove async await from createConnection * Revert of undefined check --------- Co-authored-by: magne <magnello@coders51.com>
l4mby
added a commit
that referenced
this pull request
Dec 6, 2023
* Add logger configuration * Minor fixes * Try a new version of rabbit * Try the same rabbit version as dotnet * Fix in decode response * Remove winston from deps * Remove async await from createConnection * Revert of undefined check --------- Co-authored-by: magne <magnello@coders51.com>
albertobarrila
added a commit
that referenced
this pull request
Dec 6, 2023
* skip erroneous test * chore: better naming for sub entry test * feat: reading uncompressed sub entry batch * 106-add-logger-configuration (#110) * Add logger configuration * Minor fixes * Try a new version of rabbit * Try the same rabbit version as dotnet * Fix in decode response * Remove winston from deps * Remove async await from createConnection * Revert of undefined check --------- Co-authored-by: magne <magnello@coders51.com> * chore: remove only from test * Rebase fixes * Remove skip in consuming lots of messages test * change response decoder to use the compression map of the connection * move compression retrieval to a function instead of passing all map --------- Co-authored-by: Alberto Barrilá <alberto.barrila@gmail.com> Co-authored-by: Luca <lmenghini@coders51.com> Co-authored-by: l4mby <38959260+l4mby@users.noreply.github.com> Co-authored-by: magne <magnello@coders51.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.