Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

102 performant send #120

Merged
merged 14 commits into from
Dec 20, 2023
Merged

102 performant send #120

merged 14 commits into from
Dec 20, 2023

Conversation

icappello
Copy link
Member

@icappello icappello commented Dec 11, 2023 •
edited
Loading

closes #102

Based on PR #119

@icappello icappello linked an issue Dec 11, 2023 that may be closed by this pull request
performant send #102
Closed
@icappello icappello self-assigned this Dec 11, 2023
@icappello icappello force-pushed the 102-performant-send branch 7 times, most recently from a0f1e00 to 6dd5dab Compare December 20, 2023 09:08
@icappello
add: performance test as subproject, run it in CI
aaaf8d5
@icappello
fix: producer interface after rebase
cc09748
@icappello
fix: improve readability
17072d3
@icappello
add message buffer in producer
a502a37
@icappello
add: buffer data in writer grows in size as needed, with max hard limit
22868f5
@icappello
fix test: add maxFrameSize parameter in PublishRequeest instantiation
d8cbc17
@icappello
add test for scheduled flush of producer queue
5ceafc1
@icappello
update: perftest forces NullLogger in connection object
9d30cdd
@icappello
add: write buffer size parameters (max, growth ratio, initial size) c…
235326a 
…an be passed to connection objects
@icappello
fix: passed parameters to perftest
0f2e03d
@icappello
fix: exit immediately on perftest error
f18c5bf
@icappello
fix: constant reference when computing new write buffer size
918f5d5
@icappello
update: use connection frameMax parameter when creating a new publisher
1a80b58
albertobarrila
albertobarrila previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albertobarrila
albertobarrila approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@albertobarrila albertobarrila merged commit 3910c14 into main Dec 20, 2023
1 check passed
@albertobarrila albertobarrila deleted the 102-performant-send branch December 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarzacodes tarzacodes tarzacodes left review comments

@albertobarrila albertobarrila albertobarrila approved these changes

Assignees

@icappello icappello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

performant send
3 participants
@icappello @albertobarrila @tarzacodes