Working with a load balancer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarzacodes
changed the title
icappello
previously approved these changes
Jan 5, 2024
tarzacodes
force-pushed
the
103-load-balance
branch
2 times, most recently
from
868f91a
to
e5d63cf
Compare
* feat: added client side filtering of messages if offset is of type numeric, and a bunch of tests for offsets * chore: removed useless timeout from test --------- Co-authored-by: Luca <lmenghini@coders51.com>
tarzacodes
force-pushed
the
103-load-balance
branch
from
e5d63cf
to
e1dc2ca
Compare
l4mby
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://blog.rabbitmq.com/posts/2021/07/connecting-to-streams/ - part "Client Workaround With a Load Balancer"
Basically, if we are dealing with a load balancer we cannot simply get the node and use the
advertised_hostandadvertised_port: they might be unreachable for anyone BUT the load balancer. We need to connect to the load balancer and connect to a node through it. Then check if the node we got from the LB is what we wanted (a leader for a Producer, a replica for a Consumer, anything goes for a Locator) and if it is not, close the connection and retry.ADDENDUM: All the clients I've looked thru (Java, Go, dotnet) do the matching with the advertised_host / advertised_port and I've unable to find a way to extract the actual hosts and port, therefore at least for now we shall match with those.
THEREFORE THIS NO LONGER APPLIES:
We'll use the host to match - if a LB is used whoever set up the Rabbit cluster should not have configured
advertised_hostandadvertised_portand the match should be done on the host name and port.