59 ability to consume messages from superstream #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarzacodes
force-pushed
the
59-ability-to-consume-messages-from-superstream
branch
from
13a80af
to
577a2e1
Compare
tarzacodes
deleted the
59-ability-to-consume-messages-from-superstream
branch
| @@ -310,6 +321,11 @@ export class Client { | |||
| return res.ok | |||
| } | |||
|
|
|||
| public async declareSuperStreamConsumer(superStream: string, handle: ConsumerFunc): Promise<SuperStreamConsumer> { | |||
| const partitions = await this.queryPartitions({ superStream }) | |||
| return SuperStreamConsumer.create(handle, { locator: this, consumerRef: "test", partitions }) | |||
There was a problem hiding this comment.
the consumerRef is hardcoded as "test", is it right?
| @@ -82,6 +82,7 @@ export class StreamPublisher implements Publisher { | |||
| private scheduled: NodeJS.Immediate | null | |||
| private logger: Logger | |||
| private maxChunkLength: number | |||
| private isClosed = false | |||
There was a problem hiding this comment.
I honestly do not like "is" properties, I would suggest using only closed, wdyt?
| export class SuperStreamConsumer { | ||
| private consumers: Map<string, Consumer> = new Map<string, Consumer>() | ||
| public consumerRef: string | ||
| private locator: Client |
There was a problem hiding this comment.
is locator a good name for the client underneath the consumer?
There was a problem hiding this comment.
It is the locator, that's the term we are using for the client that manages the connections right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.