Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build script before packing the npm package #41

Closed
wants to merge 1 commit into from

Conversation

akloboucnik
Copy link

@akloboucnik akloboucnik commented Sep 29, 2022

This is a follow-up of #40 - what I assume happened is that before publishing version 0.0.4 to npm registry, npm build was not run so 0.0.4 actually does not contain declaration files.

This ensures it's always run before the package is created (using npm pack).

Please beware - I've bumped the package version to 0.0.5 in package.json

@gpad
Copy link
Contributor

gpad commented Jan 4, 2023

Hi @akloboucnik, thanks for the PR. We are working on automatically publishing the npm package via CI #49, so this PR is not necessary anymore. Thanks again, and feel free to contribute again. We are working on the project to be compliant with other clients so we can publish and consume messages ASAP.

@gpad gpad closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants