Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate queryPublisherSequence in producer #68

Merged
merged 6 commits into from
Feb 2, 2023
Merged

integrate queryPublisherSequence in producer #68

merged 6 commits into from
Feb 2, 2023

Conversation

Yattol
Copy link
Contributor

@Yattol Yattol commented Jan 30, 2023

No description provided.

@Yattol Yattol self-assigned this Jan 30, 2023
@Yattol Yattol linked an issue Jan 30, 2023 that may be closed by this pull request
Integrate the Query Publisher Sequence in the producer #64
Closed
@Yattol Yattol changed the title integrate queryPublisherSequence in producer WIP:integrate queryPublisherSequence in producer Jan 30, 2023
@Yattol Yattol changed the title WIP:integrate queryPublisherSequence in producer integrate queryPublisherSequence in producer Jan 31, 2023
gpad
gpad reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@gpad gpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest to add a test that when you omit publishRef and set boot to true we start emitting from 1

test/unit/producer.test.ts Outdated Show resolved Hide resolved
test/unit/producer.test.ts Outdated Show resolved Hide resolved
gpad
gpad reviewed Jan 31, 2023
View reviewed changes
test/unit/producer.test.ts Outdated Show resolved Hide resolved
gpad
gpad previously approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gpad gpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little comment form my OCD but I like it

test/unit/producer.test.ts Outdated Show resolved Hide resolved
@Yattol Yattol merged commit 7dc8cd4 into main Feb 2, 2023
@Yattol Yattol deleted the 64-integrate-the-query-publisher-sequence-in-the-producer branch February 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpad gpad gpad approved these changes

@albertobarrila albertobarrila Awaiting requested review from albertobarrila

Assignees

@Yattol Yattol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the Query Publisher Sequence in the producer
2 participants
@Yattol @gpad