Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit #75

Merged
merged 20 commits into from
May 2, 2023
Merged

Credit #75

merged 20 commits into from
May 2, 2023

Conversation

l4mby
Copy link
Contributor

@l4mby l4mby commented Feb 9, 2023

Handle credit response from server

@l4mby l4mby requested a review from gpad February 9, 2023 14:48
@l4mby l4mby self-assigned this Feb 9, 2023
@l4mby l4mby linked an issue Feb 9, 2023 that may be closed by this pull request
Credit #16
Closed
@l4mby l4mby marked this pull request as ready for review February 14, 2023 07:08
@gpad gpad changed the title WIP: Credit Credit Apr 6, 2023
gpad
gpad reviewed Apr 6, 2023
View reviewed changes
src/connection.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
gpad
gpad reviewed Apr 14, 2023
View reviewed changes
src/connection.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
test/e2e/credit.test.ts Outdated Show resolved Hide resolved
test/e2e/credit.test.ts Outdated Show resolved Hide resolved
test/e2e/metadata_update.test.ts Outdated Show resolved Hide resolved
test/e2e/metadata_update.test.ts Outdated Show resolved Hide resolved
test/support/rabbit.ts Outdated Show resolved Hide resolved
albertobarrila
albertobarrila reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albertobarrila
albertobarrila previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gpad
gpad reviewed Apr 27, 2023
View reviewed changes
src/response_decoder.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
test/e2e/credit.test.ts Show resolved Hide resolved
@l4mby l4mby mentioned this pull request May 2, 2023
Closed
albertobarrila
albertobarrila approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all notes have been fixed, so for me is ok

@albertobarrila albertobarrila merged commit 8159eea into main May 2, 2023
@albertobarrila albertobarrila deleted the 16-credit branch May 2, 2023 12:57
@l4mby l4mby restored the 16-credit branch May 4, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertobarrila albertobarrila albertobarrila approved these changes

@gpad gpad gpad approved these changes

Assignees

@l4mby l4mby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credit
3 participants
@l4mby @albertobarrila @gpad