Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82 - Decoding of messageHeader and amqpValue #94

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

l4mby
Copy link
Contributor

@l4mby l4mby commented Jun 1, 2023

The feature is only for the decoding of these message parts in accordance with protocol amqp 1.0
The tests were done using a binary file containing the message to decode with messageHeader and amqpValue
Ref #82 #83

@l4mby l4mby requested review from albertobarrila and gpad June 1, 2023 14:55
@l4mby l4mby self-assigned this Jun 1, 2023
src/producer.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
src/response_decoder.ts Outdated Show resolved Hide resolved
test/support/util.ts Outdated Show resolved Hide resolved
albertobarrila
albertobarrila previously approved these changes Jun 19, 2023
Copy link
Contributor

@albertobarrila albertobarrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all previous comments has been resolved so looks good to me

@gpad gpad merged commit e554cbb into main Aug 21, 2023
1 check passed
@gpad gpad deleted the 82-consumer-should-read-message-header branch August 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer should read message AmqpValue Consumer should read message header
3 participants