Fix for unconfigured toolbox

codex-team · Jun 2, 2022 · dff1df2 · dff1df2
1 parent 59c6a5f
commit dff1df2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/components/tools/block.ts b/src/components/tools/block.ts
@@ -87,10 +87,10 @@ export default class BlockTool extends BaseTool<IBlockTool> {
     const userToolboxSettings = this.config[UserSettings.Toolbox];
 
     if (_.isEmpty(toolToolboxSettings)) {
-      return;
+      return [];
     }
     if (userToolboxSettings === false) {
-      return;
+      return [];
     }
     /**
      * Return tool's toolbox settings if user settings are not defined

diff --git a/src/components/ui/toolbox.ts b/src/components/ui/toolbox.ts
@@ -255,17 +255,14 @@ export default class Toolbox extends EventsDispatcher<ToolboxEvent> {
       .from(this.tools.values())
       .reduce((result, tool) => {
         const toolToolboxSettings = tool.toolbox;
-
-        if (toolToolboxSettings) {
-          const validToolboxSettings = toolToolboxSettings.filter(item => {
-            return this.areToolboxSettingsValid(item, tool.name);
-          });
-
-          result.push({
-            ...tool,
-            toolbox: validToolboxSettings,
-          });
-        }
+        const validToolboxSettings = toolToolboxSettings.filter(item => {
+          return this.areToolboxSettingsValid(item, tool.name);
+        });
+
+        result.push({
+          ...tool,
+          toolbox: validToolboxSettings,
+        });
 
         return result;
       }, []);