Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interaction): problem with entering to Editor.js by Tab key #1397

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix(interaction): problem with entering to Editor.js by Tab key #1397

merged 2 commits into from
Nov 19, 2020

Conversation

hata6502
Copy link
Contributor

@robonetphy
Copy link
Member

robonetphy commented Nov 18, 2020 •
edited
Loading

@hata6502 Can you test this bug on current version of the Editor.js.
I guess this Bug also resolve in next Branch.

@hata6502
Copy link
Contributor Author

hata6502 commented Nov 18, 2020 •
edited
Loading

@robonetphy Hello! I've tried in next branch, but this bug occurs in example/example.html
And it also can be reproduced in v2.19.0 https://editorjs.io

ezgif com-gif-maker (1)
s.io/

neSpecc
neSpecc reviewed Nov 18, 2020
View reviewed changes
src/components/modules/ui.ts Outdated
@@ -750,6 +750,8 @@ export default class UI extends Module<UINodes> {
return;
}

this.Editor.BlockManager.setCurrentBlockByChildNode(focusedElement);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will be called many times when user will do selecting some text fragment. Maybe we can provide some optimizations?

@neSpecc neSpecc changed the title Fix problem with entering to Editor.js by Tab key fix(interaction): problem with entering to Editor.js by Tab key Nov 19, 2020
@neSpecc neSpecc merged commit 113e895 into codex-team:next Nov 19, 2020
@hata6502 hata6502 deleted the bugfix/fix-tab-entering branch November 19, 2020 12:59
neSpecc pushed a commit that referenced this pull request Dec 8, 2020
@hata6502 @neSpecc
fix(interaction): problem with entering to Editor.js by Tab key (#1397)
bbb4758 
* Fix problem with entering to Editor.js by Tab key
* Optimize current block setting

Co-authored-by: t.hata <hata@impact-blue.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@robonetphy robonetphy robonetphy approved these changes

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@khaydarov khaydarov Awaiting requested review from khaydarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hata6502 @robonetphy @neSpecc