Fix unstable block cut process #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hata6502
requested review from
gohabereg,
khaydarov and
neSpecc
as code owners
hata6502
commented
Dec 22, 2020
| const { BlockSelection, BlockManager, Caret } = this.Editor; | ||
|
|
||
| if (!BlockSelection.anyBlockSelected) { | ||
| return; | ||
| } | ||
|
|
||
| BlockSelection.copySelectedBlocks(event); | ||
| await BlockSelection.copySelectedBlocks(event); |
There was a problem hiding this comment.
Fix the weakness of block cut program.
If await is used in copySelectedBlocks,
removeSelectedBlocks is executed before copySelectedBlocks
hata6502
commented
Dec 22, 2020
| const { BlockSelection, BlockManager, Caret } = this.Editor; | ||
|
|
||
| if (!BlockSelection.anyBlockSelected) { | ||
| return; | ||
| } | ||
|
|
||
| BlockSelection.copySelectedBlocks(event); | ||
| await BlockSelection.copySelectedBlocks(event); | ||
|
|
||
| const selectionPositionIndex = BlockManager.removeSelectedBlocks(); |
There was a problem hiding this comment.
This line may be executed before copySelectedBlocks()!
neSpecc
approved these changes
Feb 18, 2021
khaydarov
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1489