Fixed sanitizer on pasting HTML #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2021 12:21
|
Any ETA for this fix? |
|
@neSpecc @khaydarov @gohabereg are you planning to check this pull request in the near future? This would be really great 🚀 |
|
Any news on it ? The bug appeared since 2.20.0 |
|
@gohabereg @khaydarov @neSpecc, Hi! Could you please check this PR? |
swapster
added a commit
to swapster/editor.js
that referenced
this pull request
Feb 2, 2022
|
Also waiting for this to get merged 🙏 |
swapster
added a commit
to swapster/editor.js
that referenced
this pull request
Feb 14, 2022
swapster
added a commit
to swapster/editor.js
that referenced
this pull request
Feb 14, 2022
neSpecc
requested changes
Apr 26, 2022
| @@ -662,7 +662,7 @@ export default class Paste extends Module { | |||
|
|
|||
| /** If there is no pattern substitute - insert string as it is */ | |||
| if (BlockManager.currentBlock && BlockManager.currentBlock.currentInput) { | |||
| const currentToolSanitizeConfig = BlockManager.currentBlock.tool.sanitizeConfig; | |||
| const currentToolSanitizeConfig = BlockManager.currentBlock.tool.baseSanitizeConfig; | |||
There was a problem hiding this comment.
looks like the sanitizeConfig works wrong and we would better to fix it. Need to dig deeper.
|
Looks like the PR is correct, but we have a problem with naming. See #2029 |
gohabereg
approved these changes
Apr 26, 2022
neSpecc
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I paste HTML text, sanitizer remove all inline tags and render only inner text. Because to HTMLJanitor passing wrong config.