Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pass user configuration to Tool prepare method #1781

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

gohabereg
Copy link
Member

No description provided.

@Broutard
Copy link

Please validate this PR which solve editor-js/embed#68

@@ -279,7 +279,7 @@ export default class Tools extends Module {
}[] {
const toolPreparationList: {
function: (data: { toolName: string }) => void | Promise<void>;
data: { toolName: string };
data: { toolName: string; config: ToolConfig };
Copy link
Member

@neSpecc neSpecc Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add this to the function's return type

@georgeciubotaru
Copy link

@neSpecc Are you guys planning to fix this issue, or we are chilling now?

@Broutard
Copy link

It would be really appreciated if this bug could be fixed quickly, please.
We cannot update after 2.19.3 because of this issue.

@gohabereg do you have time to do this ?

@gohabereg
Copy link
Member Author

resolves editor-js/embed#68
resolves editor-js/embed#60
resolves editor-js/embed#72

@gohabereg gohabereg enabled auto-merge (squash) September 16, 2021 14:17
@gohabereg gohabereg merged commit a3df3b8 into next Sep 16, 2021
@Farrien
Copy link

Farrien commented Oct 8, 2021

This fix took 5-6 months LMAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants