Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnChange Event Invocation #2007

Merged
merged 8 commits into from
Apr 7, 2022
Merged

Fix OnChange Event Invocation #2007

merged 8 commits into from
Apr 7, 2022

Conversation

robonetphy
Copy link
Member

resolve #1997

@robonetphy robonetphy requested review from neSpecc, gohabereg and khaydarov and removed request for neSpecc, khaydarov and gohabereg March 31, 2022 15:35
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@robonetphy
Copy link
Member Author

@gohabereg I checked tests with next branch is failing.
onChange callback -- should fire onChange callback on block insertion with save inside onChange (failed)

@robonetphy robonetphy merged commit 18feb06 into next Apr 7, 2022
@neSpecc neSpecc deleted the fix/onchange_event branch April 7, 2022 09:29
@drakst
Copy link

drakst commented Apr 20, 2022

Hi. Instead of onChange event you can try to connect MutationObserver to editor ad watch for updates.

Config of observe can be something like: {
attributes: false,
childList: true,
subtree: true,
characterData: true
}

Im using this config on vue project for change v-model value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onChange event not called when adding new block
5 participants