Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbar): layout shrink after blocks removing #2484

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

neSpecc
Copy link
Member

@neSpecc neSpecc commented Sep 19, 2023

Problem

When you have a large document, selecting all blocks and removing them, the editor height does not change back to a min-height.

Reason

It happened because the Toolbar and Inline Toolbar still have a large top coord value, and Chrome does not recalculate the height correctly for some reason.

image

Solution

I've added the resetting of the Toolbar and Inline Toolbar positions on their close.

Also

  • Fixed of focusing out-of-viewport Block
  • Get rid of multiple CodeX Tooltip initializations by different modules.

image

@neSpecc neSpecc merged commit ec569f9 into next Sep 20, 2023
6 checks passed
@neSpecc neSpecc deleted the fix/toolbar-layout-shrink branch September 21, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants