Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Spark notebook and environment #45

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add simple Spark notebook and environment #45

merged 2 commits into from
Apr 23, 2024

Conversation

mrocklin
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrocklin. I've not actual run this notebook, but I've assumed you have and things work well (happy to run myself if you'd like).

My only comment, which is a non-blocking nit, is if the dask.config.set({"dataframe.convert-string": True}) line is needed. Maybe an old version of Dask, where this isn't the default, is getting pulled in?

@jrbourbeau
Copy link
Member

Actually, is that last cell needed at all? Is looks like it's just Dask, not Spark? Maybe this comes up in the talk-track?

@mrocklin
Copy link
Member Author

Ah, thanks. Fixed.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- will merge after CI is done

@jrbourbeau jrbourbeau merged commit fc40637 into main Apr 23, 2024
3 checks passed
@jrbourbeau jrbourbeau deleted the spark branch April 23, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants