feat: EIP-5792 in OnchainKitProvider
#1181
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/useCapabilitiesSafe.ts
Outdated
|
|
||
| // Metamask doesn't support wallet_getCapabilities | ||
| const isMetamaskWallet = connector?.id === 'io.metamask'; | ||
| const enabled = isConnected && !isMetamaskWallet; |
There was a problem hiding this comment.
optionally we can also just check for error returned from useCapabilities but there will still be an error displayed in the console for unsupported RPCs - IMO this is a more scalable solution than manually excluding individual connector IDs
There was a problem hiding this comment.
cc @alissacrane-cb on Tanstack query best practices
src/useCapabilitiesSafe.ts
Outdated
| import type { WalletCapabilities } from './types'; | ||
|
|
||
| export function useCapabilitiesSafe({ | ||
| chain, |
There was a problem hiding this comment.
Going forward we are moving away from using chain, instead we will have directly chainId.
There was a problem hiding this comment.
changed in latest diff
| paymaster: boolean; // If the wallet supports ERC-4337 Paymasters for gas sponsorship | ||
| batching: boolean; // If the wallet supports atomic batching of transactions | ||
| funding: boolean; // If the wallet supports auxiliary funding of accounts (e.g. Magic Spend) | ||
| }; |
There was a problem hiding this comment.
mmmm if those are boolean, probably we should use the has prefix
export type WalletCapabilities = {
hasPaymasterSupport: boolean;
hasBatchingSupport: boolean;
hasFundingSupport: boolean;
};
There was a problem hiding this comment.
let's continue this discussion on Wilson's comment below
| export function useCapabilitiesSafe({ | ||
| chainId, | ||
| }: UseCapabilitiesSafeParams): WalletCapabilities { | ||
| const { isConnected } = useAccount(); |
There was a problem hiding this comment.
Btw as follow up PR, check with @abcrane123 if this will cause a SSR issue.
There was a problem hiding this comment.
i don't think this will be an issue
src/useCapabilitiesSafe.ts
Outdated
| return { | ||
| hasPaymasterService: capabilities[chainId]?.paymasterService?.supported, | ||
| hasAtomicBatch: capabilities[chainId]?.atomicBatch?.supported, | ||
| hasAuxiliaryFunds: capabilities[chainId]?.auxiliaryFunds?.supported, |
There was a problem hiding this comment.
if these can be undefined, should they be cast to a boolean?
There was a problem hiding this comment.
should be fine per this test?
There was a problem hiding this comment.
that just tests if !capabilities though right? is it possible for useCapabilities to return some of the capabilities, but not all?
There was a problem hiding this comment.
good catch :) fixed in the latest diff!
What changed? Why?
useCapabilitiesSafehookOnchainKitProviderfor consumption in child componentsNotes to reviewers
How has it been tested?
unit tests and console logging the capabilities on Playground