feat: Add Swap Settings v1 api support #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
Zizzamia
reviewed
Aug 29, 2024
Zizzamia
reviewed
Aug 29, 2024
Zizzamia
reviewed
Aug 30, 2024
| let slippagePercentage = params.maxSlippage; | ||
| // Adjust slippage for V1 API (aggregator) | ||
| // V1 expects slippage in tenths of a percent (e.g., 30 = 3%) | ||
| if (params.useAggregator) { |
There was a problem hiding this comment.
I still don't follow, is useAggregator: true what everyone uses at the moment?
If that so, we should not change this code.
There was a problem hiding this comment.
tl;dr: No one should be using useAggregator: true
There are two different APIs, V1 wallet/swap-service and V2 cloud/swap-router.
V1:
useAggregator: true- Expects slippage in tenths of a percent (e.g., 30 = 3%) which is why we must multiply
maxSlippageby 10 before sending the request.
V2:
useAggregator: false- Expects slippage in a percent, which is why we do not have to adjust the
maxSlippagevalue.
PartyDOA is the only known customer who is using the maxSlippage parameter. No other user is using the maxSlippage parameter, and therefore they are defaulting to a hard coded slippage value of 10%.
I know this is confusing, but we are planning to deprecate the V1 API once we deprecate the experimental prop.
cpcramer
force-pushed
the
paul/swap-Settings-api
branch
from
4a96c04
to
10ce2b1
Compare
cpcramer
force-pushed
the
paul/swap-Settings-api
branch
from
3c01a71
to
9be06de
Compare
Zizzamia
approved these changes
Aug 30, 2024
cpcramer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?