Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS compilation perf: faster objectUtil.addQuestionMarks #2845

Merged

Commits on Apr 19, 2024

  1. Update docs

    colinhacks committed Apr 19, 2024
    1 Configuration menu
    Copy the full SHA
    f4175b3 View commit details
    Browse the repository at this point in the history
  2. Add PR template

    colinhacks committed Apr 19, 2024
    1 Configuration menu
    Copy the full SHA
    42c5dc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. TS compilation perf: faster objectUtil.addQuestionMarks

    I'm not sure what the precise reasons for this being faster are,
    but consistently benchmarking in my project about 50% more type
    instantiations with the original version vs. the one proposed in
    this commit; plus the compilation time is 20% longer in the original.
    jussisaurio authored and colinhacks committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    4962235 View commit details
    Browse the repository at this point in the history
  2. Simplify objectUtil.addQuestionMarks

    The previous commit contained some pseudo-optimizations that had
    no realworld impact.
    jussisaurio authored and colinhacks committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    365ada0 View commit details
    Browse the repository at this point in the history
  3. Simplify objectUtil.addQuestionMarks again

    Turns out requiredKeys is not necessary and filtering out
    optional keys in the mapped type's key filtering does the
    same thing. This also further reduces the amount of type
    instantiations which slightly improves performance.
    jussisaurio authored and colinhacks committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    73efb93 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50dcc45 View commit details
    Browse the repository at this point in the history