Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit preprocess only on own errors #3124

Closed
wants to merge 2 commits into from

Conversation

selimb
Copy link

@selimb selimb commented Jan 10, 2024

Fixes #3123

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 83e8ea4
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/659ea146e6a71d0008afc5d3
😎 Deploy Preview https://deploy-preview-3124--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haines
Copy link

haines commented Jan 24, 2024

We ran into #3123 when using the zfd.text helper from zod-form-data: https://github.com/airjp73/remix-validated-form/issues/349

I've applied this PR using patch-package and can confirm it resolves the issue for us.

@selimb
Copy link
Author

selimb commented Feb 16, 2024

Duplicate of #2912. Looks like there were multiple issues/PRs for the same thing.

@selimb selimb closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of z.object props with preprocess gives wrong parse results
2 participants