Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor Console Corporate CLA flow when there is a signed CLA Step 3 #47

Merged
merged 10 commits into from
Jun 25, 2020
Merged

Contributor Console Corporate CLA flow when there is a signed CLA Step 3 #47

merged 10 commits into from
Jun 25, 2020

Conversation

amolsontakke3576
Copy link
Contributor

Screenshot from 2020-06-25 17-46-03

Screenshot from 2020-06-25 17-46-36

Screenshot from 2020-06-25 17-37-34

Screenshot from 2020-06-25 17-28-28

@amolsontakke3576
[#1016] Changed UI as per new theme
a77bd84 
Updated add company regex as per organization service

Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1009] Integrated cla manager list API
431cbb6 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
Merge branch 'feature/1016_add-organization_UI_change' of github.com:…
67fe2e9 
…amolsontakke3576/easycla-contributor-console into feature/1009_request_authorization
@amolsontakke3576
[#1009] Completed UI and client side validation
f86b431 
Integrated notify cla manager endpoint

Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1009] solved lint issue
c4c8533 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1009] Added CCLA require ICLA signature flow
3864246 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1009] Completed request authorization flow with ccla require ICLA
f0804b5 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1009] Solved diloag close issue
351eaaa 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576 amolsontakke3576 added the enhancement New feature or request label Jun 25, 2020
@amolsontakke3576 amolsontakke3576 self-assigned this Jun 25, 2020
@amolsontakke3576
[#1009] Solved issue of showing 3 result on CLA manager screen
2e54376 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
dealako
dealako requested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@dealako dealako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue with text - conflict merge artifact.

...p/modules/corporate-contributor/component/add-company-modal/add-company-modal.component.html Outdated Show resolved Hide resolved
@amolsontakke3576
[#1009] solved conflict head
1df8d2e 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
dealako
dealako approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@dealako dealako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dealako dealako merged commit cf0ac51 into communitybridge:master Jun 25, 2020
@amolsontakke3576 amolsontakke3576 deleted the feature/1009_request_authorization branch November 9, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dealako dealako dealako approved these changes

@nirupamav nirupamav Awaiting requested review from nirupamav

Assignees

@amolsontakke3576 amolsontakke3576

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolsontakke3576 @dealako