-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phoenix Runner #41
Phoenix Runner #41
Conversation
please rebase so there aren't so many commits |
i took out the the line that lets you see a PR's commits on master but okay i'll try. the commit history on this is really complicated from having to add and remove my own cases. |
this has commits from 3 weeks ago? |
yeah i basically kept the same branch that i made other PRs from but ran a "git merge master" after pulling the PR onto master and never started a new branch, so the real differences start after #8ec18f5. sorry this is so hacky, i'm trying to resolve conflicts in the rebase now, but there's conflicts in all 96 commits, so it's too cumbersome. |
I just reset the commit history. Some of the Makefiles on the branch might look old, but that was because I gave all the case files unique names, so a global Makefile wasn't gonna work anymore without some wildcards. I'm hoping Makefiles can be completely removed in the future though if I'm happy with cmake. It handles everything pretty dynamically, but if you need a better explanation of the system I set up, I can try! |
Maybe someone else could help with the review if they're familiar with cmake? It's pretty much identical to Makefile.in and PETSc's official cmake. |
@sbryngelson look Phoenix runner works! I'm not putting a MacOS runner in the same PR though cause there's already too much here. The CMake works on Mac too though. |
All the updates in this PR:
/build
/packages
forml gcc/12.1.0-qgxpzk mvapich2/2.3.7-733lcv
to work since the FFTW module depends onmvapich2/2.3.6-ouywal
, and that one is broken inside the Phoenix runner. This install script is now underinstall-phoenix.sh
, but it’s more of a worst-case scenario becauseinstall.sh
works for me on Phoenix.install.sh
does work on the ICE runner because the ICE FFTW depends on the defaultmvapich2/2.3.7-1
already.Makefile.in
isn't flexible at all though (there's nothing I can do about this), so it doesn't work with all builds.