Add switch React version #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
force-pushed
the
feat-switch-react-version
branch
from
d9bd5e1
to
721904b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
Specific changes
strategy.matrix.react-versionto pull request validation to test against16.9.0,17.0.0,18.0.0and current (as committed)switch:react:*to temporarily switch React versions by manually modifying dependenciesDesigns
The added
switch:react:*scripts are one-way door. After the switch, the modified files includingpackage-lock.jsonmust be discarded and never committed to the repository.We are using
--legacy-peer-depsduring the switch. Otherwise, NPM will pick up the latest possible version, instead of honoring the specified version. In other words, without--legacy-peer-deps, it will install latest availablereact@18.2.0at the root/node_modules/react/as it is required by@fluentui/*(>=16.8.0 <19.0.0) thru/packages/pages/. And NPM will leavereact@16.9.0under individual/packages/*/node_modules/.